Add preference option for non-buffered file handling in Xtext editors.#1517
Add preference option for non-buffered file handling in Xtext editors.#1517raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a UI preference to control “non-buffered file handling” so LSP4E can better support editors (e.g., Xtext) whose IDocument is not backed by Eclipse file buffers, aligning with #1500.
Changes:
- Added a new translatable UI label for the preference.
- Exposed a new checkbox on the Language Server preference page backed by
org.eclipse.lsp4e.resourceFallback.enabled. - Persisted the checkbox value to the plugin preference store on OK.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/messages.properties |
Adds the UI string for the new preference checkbox. |
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/Messages.java |
Exposes the new message key to the NLS bundle. |
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java |
Adds the checkbox and saves/loads the preference value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
Show resolved
Hide resolved
|
Hi @raghucssit , I think the end user should not be interested in such flag. Could we instead enable it in the Activator of CoPilot plugin? |
raghucssit
force-pushed
the
pref-non-fb-res-lisn
branch
from
276013c to
c7e9636
Compare
The point is, it is needed by Xtext & Copilot (as of today), but provided by LSP4E. If there will be some other plugin that needs same preference, should there be another preference page? Surely not. I don't see a big problem in providing an option in LSP4E for this feature, if there will be no complains with the new code, it can be removed later. @raghucssit : can you please attach a screenshot of the preference page? I do not have time to load this patch into IDE, and code reading doesn't replace visual check. Beside this, I miss one important thing in this PR: the new support should by enabled by default with this preference page, that is one of the main reasons to have the page at all - if the new support breaks something in LSP4E/clients of it, it should be possible to users to fix that without waiting for new release. |
see #1500